From 5ec14fd981c27f9a3ce64922b54252ec5cabbc18 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 17 Feb 2018 20:45:22 +0100 Subject: [PATCH] libdgram: Remove an unused parameter Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider --- source4/libcli/dgram/libdgram.h | 3 +-- source4/libcli/dgram/netlogon.c | 7 +++---- source4/nbt_server/irpc.c | 2 +- source4/torture/nbt/dgram.c | 3 ++- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/source4/libcli/dgram/libdgram.h b/source4/libcli/dgram/libdgram.h index 64a91272058..0f313a67cf5 100644 --- a/source4/libcli/dgram/libdgram.h +++ b/source4/libcli/dgram/libdgram.h @@ -131,8 +131,7 @@ NTSTATUS dgram_mailslot_netlogon_parse_request(TALLOC_CTX *mem_ctx, struct nbt_dgram_packet *dgram, struct nbt_netlogon_packet *netlogon); -NTSTATUS dgram_mailslot_netlogon_parse_response(struct dgram_mailslot_handler *dgmslot, - TALLOC_CTX *mem_ctx, +NTSTATUS dgram_mailslot_netlogon_parse_response(TALLOC_CTX *mem_ctx, struct nbt_dgram_packet *dgram, struct nbt_netlogon_response *netlogon); diff --git a/source4/libcli/dgram/netlogon.c b/source4/libcli/dgram/netlogon.c index f224afda79d..25612acc6d0 100644 --- a/source4/libcli/dgram/netlogon.c +++ b/source4/libcli/dgram/netlogon.c @@ -123,10 +123,9 @@ NTSTATUS dgram_mailslot_netlogon_parse_request(TALLOC_CTX *mem_ctx, /* parse a netlogon response. The packet must be a valid mailslot packet */ -NTSTATUS dgram_mailslot_netlogon_parse_response(struct dgram_mailslot_handler *dgmslot, - TALLOC_CTX *mem_ctx, - struct nbt_dgram_packet *dgram, - struct nbt_netlogon_response *netlogon) +NTSTATUS dgram_mailslot_netlogon_parse_response(TALLOC_CTX *mem_ctx, + struct nbt_dgram_packet *dgram, + struct nbt_netlogon_response *netlogon) { NTSTATUS status; DATA_BLOB data = dgram_mailslot_data(dgram); diff --git a/source4/nbt_server/irpc.c b/source4/nbt_server/irpc.c index 261e066b16b..cfe617b53b0 100644 --- a/source4/nbt_server/irpc.c +++ b/source4/nbt_server/irpc.c @@ -70,7 +70,7 @@ static void getdc_recv_netlogon_reply(struct dgram_mailslot_handler *dgmslot, struct nbt_netlogon_response netlogon; NTSTATUS status; - status = dgram_mailslot_netlogon_parse_response(dgmslot, packet, packet, + status = dgram_mailslot_netlogon_parse_response(packet, packet, &netlogon); if (!NT_STATUS_IS_OK(status)) { DEBUG(5, ("dgram_mailslot_ntlogon_parse failed: %s\n", diff --git a/source4/torture/nbt/dgram.c b/source4/torture/nbt/dgram.c index 549ecad1f94..2f7ea19443f 100644 --- a/source4/torture/nbt/dgram.c +++ b/source4/torture/nbt/dgram.c @@ -51,7 +51,8 @@ static void netlogon_handler(struct dgram_mailslot_handler *dgmslot, printf("netlogon reply from %s:%d\n", src->addr, src->port); /* Fills in the netlogon pointer */ - status = dgram_mailslot_netlogon_parse_response(dgmslot, netlogon, packet, netlogon); + status = dgram_mailslot_netlogon_parse_response(netlogon, packet, + netlogon); if (!NT_STATUS_IS_OK(status)) { printf("Failed to parse netlogon packet from %s:%d\n", src->addr, src->port);