sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

s4:dsdb: Permit forward link to be missing in linked_attributes_fix_forward_link()

Browse Source 
We don’t care if a forward link is missing from an object being renamed
during the deletion process.

Nothing yet checks the value returned from this function, so there
should be no change in behaviour.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-10-09 11:55:10 +13:00 committed by Andrew Bartlett
parent d0db0ff268
commit 61037a85bf
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source4/dsdb/samdb/ldb_modules/linked_attributes.c
View File

@ -842,13 +842,15 @@ static int linked_attributes_fix_forward_link(struct ldb_module *module,
}
if (exact == NULL) {
ldb_asprintf_errstring(
ldb,
"parsed_dn_find could not find %s link for %s",
el->name,
ldb_dn_get_linearized(msg->dn));
/*
* Our only caller doesn’t want to know about errors finding a
* forward link for which we have a backlink — in particular,
* during the tombstoning of an object, the forward links have
* already been removed when this routine is called by
* dsdb_module_rename() inside replmd_delete_internals().
*/
talloc_free(tmp_ctx);
return LDB_ERR_OPERATIONS_ERROR;
return LDB_SUCCESS;
}
is_plain_dn = strcmp(syntax_oid, LDB_SYNTAX_DN) == 0;