sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00
Code

s3-rpc_server: Only allow registering endpoints on priviledged pipes.

Browse Source
This commit is contained in:
Andreas Schneider 2011-01-04 09:52:57 +01:00 committed by Andreas Schneider
parent 31779662b7
commit 612060d677
1 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
source3/rpc_server/srv_epmapper.c
View File

@ -20,6 +20,7 @@
*/ */
#include "includes.h" #include "includes.h"
#include "../libcli/security/security.h"
#include "librpc/gen_ndr/ndr_epmapper.h" #include "librpc/gen_ndr/ndr_epmapper.h"
#include "librpc/gen_ndr/srv_epmapper.h" #include "librpc/gen_ndr/srv_epmapper.h"
@ -202,6 +203,16 @@ static uint32_t build_ep_list(TALLOC_CTX *mem_ctx,
return total; return total;
} }
static bool is_priviledged_pipe(struct auth_serversupplied_info *info) {
/* If the user is not root, or has the system token, fail */
if ((info->utok.uid != sec_initial_uid()) &&
!security_token_is_system(info->ptok)) {
return false;
}
return true;
}
/* /*
* epm_Insert * epm_Insert
* *
@ -215,6 +226,11 @@ error_status_t _epm_Insert(struct pipes_struct *p,
NTSTATUS status; NTSTATUS status;
uint32_t i; uint32_t i;
/* If this is not a priviledged users, return */
if (!is_priviledged_pipe(p->server_info)) {
return EPMAPPER_STATUS_CANT_PERFORM_OP;
}
tmp_ctx = talloc_stackframe(); tmp_ctx = talloc_stackframe();
if (tmp_ctx == NULL) { if (tmp_ctx == NULL) {
return EPMAPPER_STATUS_NO_MEMORY; return EPMAPPER_STATUS_NO_MEMORY;
@ -223,8 +239,6 @@ error_status_t _epm_Insert(struct pipes_struct *p,
DEBUG(3, ("_epm_Insert: Trying to add %u new entries.\n", DEBUG(3, ("_epm_Insert: Trying to add %u new entries.\n",
r->in.num_ents)); r->in.num_ents));
/* TODO Check if we have a priviledged pipe/handle */
for (i = 0; i < r->in.num_ents; i++) { for (i = 0; i < r->in.num_ents; i++) {
struct dcerpc_binding *b = NULL; struct dcerpc_binding *b = NULL;
struct dcesrv_endpoint *ep; struct dcesrv_endpoint *ep;
@ -328,13 +342,16 @@ error_status_t _epm_Delete(struct pipes_struct *p,
DEBUG(3, ("_epm_Delete: Trying to delete %u entries.\n", DEBUG(3, ("_epm_Delete: Trying to delete %u entries.\n",
r->in.num_ents)); r->in.num_ents));
/* If this is not a priviledged users, return */
if (!is_priviledged_pipe(p->server_info)) {
return EPMAPPER_STATUS_CANT_PERFORM_OP;
}
tmp_ctx = talloc_stackframe(); tmp_ctx = talloc_stackframe();
if (tmp_ctx == NULL) { if (tmp_ctx == NULL) {
return EPMAPPER_STATUS_NO_MEMORY; return EPMAPPER_STATUS_NO_MEMORY;
} }
/* TODO Check if we have a priviledged pipe/handle */
for (i = 0; i < r->in.num_ents; i++) { for (i = 0; i < r->in.num_ents; i++) {
struct dcerpc_binding *b = NULL; struct dcerpc_binding *b = NULL;
struct dcesrv_endpoint *ep; struct dcesrv_endpoint *ep;