sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-03 01:18:10 +03:00
Code

buildtools: Remove useless ‘keep_underscore’ parameter

Browse Source 
SAMBA_LIBARY()’s ‘keep_underscore’ parameter has an effect only if None
is passed in for ‘bundled_name’. However, SAMBA_PLUGIN() always passes
in a string for ‘bundled_name’. Therefore ‘keep_underscore’ will never
have any effect — remove it.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-11-13 09:39:20 +13:00 committed by Andrew Bartlett
parent e3ad675303
commit 623645963e
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
buildtools/wafsamba/wafsamba.py
View File

@ -654,7 +654,6 @@ def SAMBA_PLUGIN(bld, pluginname, source,
vars=None, vars=None,
subdir=None, subdir=None,
realname=None, realname=None,
keep_underscore=False,
autoproto=None, autoproto=None,
autoproto_extra_source='', autoproto_extra_source='',
install_path=None, install_path=None,
@ -686,7 +685,6 @@ def SAMBA_PLUGIN(bld, pluginname, source,
cflags=cflags, cflags=cflags,
ldflags=ldflags, ldflags=ldflags,
realname=realname, realname=realname,
keep_underscore=keep_underscore,
autoproto=autoproto, autoproto=autoproto,
autoproto_extra_source=autoproto_extra_source, autoproto_extra_source=autoproto_extra_source,
local_include=local_include, local_include=local_include,

2
nsswitch/wscript_build
View File

@ -36,7 +36,6 @@ bld.SAMBA_PLUGIN('nss_wrapper_winbind',
if (Utils.unversioned_sys_platform() == 'linux' or (host_os.rfind('gnu') > -1)): if (Utils.unversioned_sys_platform() == 'linux' or (host_os.rfind('gnu') > -1)):
bld.SAMBA_PLUGIN('nss_winbind', bld.SAMBA_PLUGIN('nss_winbind',
keep_underscore=True,
cflags='-D_PUBLIC_ON_LINUX_=_PUBLIC_', cflags='-D_PUBLIC_ON_LINUX_=_PUBLIC_',
source='winbind_nss_linux.c', source='winbind_nss_linux.c',
deps='wbclient', deps='wbclient',
@ -45,7 +44,6 @@ if (Utils.unversioned_sys_platform() == 'linux' or (host_os.rfind('gnu') > -1)):
vnum='2') vnum='2')
bld.SAMBA3_PLUGIN('nss_wins', bld.SAMBA3_PLUGIN('nss_wins',
keep_underscore=True,
cflags='-D_PUBLIC_ON_LINUX_=_PUBLIC_', cflags='-D_PUBLIC_ON_LINUX_=_PUBLIC_',
source='wins.c', source='wins.c',
deps='wbclient replace', deps='wbclient replace',