sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

KCC improve docstring for update_rodc_connection()

Browse Source 
Also make a short-cut early exit visually shorter and earlier.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2015-05-06 18:05:21 +12:00 committed by Andrew Bartlett
parent 257219c836
commit 62a7ae5727
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
python/samba/kcc/__init__.py
View File

@ -1923,9 +1923,13 @@ class KCC(object):
return all_connected return all_connected
def update_rodc_connection(self): def update_rodc_connection(self):
"""Runs when the local DC is an RODC and updates the RODC NTFRS """Updates the RODC NTFRS connection object.
connection object.
If the local DSA is not an RODC, this does nothing.
""" """
if not self.my_dsa.is_ro():
return
# Given an nTDSConnection object cn1, such that cn1.options contains # Given an nTDSConnection object cn1, such that cn1.options contains
# NTDSCONN_OPT_RODC_TOPOLOGY, and another nTDSConnection object cn2, # NTDSCONN_OPT_RODC_TOPOLOGY, and another nTDSConnection object cn2,
# does not contain NTDSCONN_OPT_RODC_TOPOLOGY, modify cn1 to ensure # does not contain NTDSCONN_OPT_RODC_TOPOLOGY, modify cn1 to ensure
@ -1937,9 +1941,6 @@ class KCC(object):
# If no such cn2 can be found, cn1 is not modified. # If no such cn2 can be found, cn1 is not modified.
# If no such cn1 can be found, nothing is modified by this task. # If no such cn1 can be found, nothing is modified by this task.
if not self.my_dsa.is_ro():
return
all_connections = self.my_dsa.connect_table.values() all_connections = self.my_dsa.connect_table.values()
ro_connections = [x for x in all_connections if x.is_rodc_topology()] ro_connections = [x for x in all_connections if x.is_rodc_topology()]
rw_connections = [x for x in all_connections rw_connections = [x for x in all_connections