sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-08 05:57:51 +03:00
Code

s3:clispnego: fix confusing warning in spnego_gen_krb5_wrap()

Browse Source 
asn1_extract_blob() stops further asn1 processing by setting has_error.

Don't call asn1_has_error() after asn1_extract_blob() has been successful
otherwise we get an "Failed to build krb5 wrapper at" message
on success.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11702

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11804

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 14f1a94b6fb3a55be1e60fe0d28740f04fd94b3f)
(cherry picked from commit c17b1f697c388bd2e0190c4a3574d951b8be483e)
This commit is contained in:
Stefan Metzmacher 2016-01-28 15:50:06 +01:00
parent 5bbf46e204
commit 62e5169cd7
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
source3/libsmb/clispnego.c
View File

@ -262,14 +262,19 @@ DATA_BLOB spnego_gen_krb5_wrap(TALLOC_CTX *ctx, const DATA_BLOB ticket, const ui
goto err;
}
asn1_free(data);
data = NULL;
err:
if (asn1_has_error(data)) {
DEBUG(1, ("Failed to build krb5 wrapper at offset %d\n",
(int)asn1_current_ofs(data)));
}
if (data != NULL) {
if (asn1_has_error(data)) {
DEBUG(1, ("Failed to build krb5 wrapper at offset %d\n",
(int)asn1_current_ofs(data)));
}
asn1_free(data);
asn1_free(data);
}
return ret;
}