sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

build: Put the note from the bottom of the old BUILD_SYSTEMS.txt somewhere useful

Browse Source 
This statement on how we handle --with options is best placed near where
the options are set, so developers see it when trying to choose the
correct thing to do.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Andrew Bartlett 2020-06-03 16:06:34 +12:00 committed by Jeremy Allison
parent bfe4e84bb9
commit 6446e86b54
3 changed files with 43 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
buildtools/wafsamba/samba_utils.py
View File

@ -719,6 +719,9 @@ def samba_before_apply_obj_vars(self):
if is_standard_libpath(v, i):
v['LIBPATH'].remove(i)
# Samba options are mostly on by default (administrators and packagers
# specify features to remove, not add), which is why default=True
def samba_add_onoff_option(opt, option, help=(), dest=None, default=True,
with_name="with", without_name="without"):
if default is None:

21
source3/wscript
View File

@ -40,6 +40,27 @@ def options(opt):
"--with-shared-modules"),
action="store", dest='shared_modules', default=None)
# Optional Libraries
# ------------------
#
# Most of the calls to opt.samba_add_onoff_option() implicitly
# or explicity use default=True
#
# To assist users and distributors to build Samba with the full feature
# set, the build system will abort if our dependent libraries and their
# header files are not found on the target system. This will mean for
# example, that xattr, acl and ldap headers must be installed for the
# default build to complete. The configure system will check for these
# headers, and the error message will indicate the option (such as
# --without-acl-support) that can be specified to skip this requirement.
#
# This will assist users and in particular distributors in building fully
# functional packages, while allowing those on systems truly without these
# facilities to continue to build Samba after careful consideration.
#
# It also ensures our container image generation in bootstrap/ is correct
# as otherwise a missing package there would just silently work
opt.samba_add_onoff_option('winbind')
opt.samba_add_onoff_option('ads')
opt.samba_add_onoff_option('ldap')

19
wscript
View File

@ -47,6 +47,25 @@ def options(opt):
opt.RECURSE('lib/crypto')
opt.RECURSE('ctdb')
# Optional Libraries
# ------------------
#
# Most of the calls to opt.add_option() use default=True for the --with case
#
# To assist users and distributors to build Samba with the full feature
# set, the build system will abort if our dependent libraries and their
# header files are not found on the target system. This will mean for
# example, that xattr, acl and ldap headers must be installed for the
# default build to complete. The configure system will check for these
# headers, and the error message will indicate the option (such as
# --without-acl-support) that can be specified to skip this requirement.
#
# This will assist users and in particular distributors in building fully
# functional packages, while allowing those on systems truly without these
# facilities to continue to build Samba after careful consideration.
#
# It also ensures our container image generation in bootstrap/ is correct
# as otherwise a missing package there would just silently work
opt.samba_add_onoff_option('pthreadpool', with_name="enable", without_name="disable", default=True)