From 64aea70f9f80acec2ba4f5da44e413f2f91c75c0 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Wed, 2 Feb 2022 10:52:09 -0800 Subject: [PATCH] lib: libsmbclient: Ensure cli_rename() always sets cli->raw_status. Identical change as used in cli_unlink(), cli_mkdir(), cli_rmdir() cli_chkpath() to ensure SMB2 calls correctly set raw_status for libsmbclient uses. Remove knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14938 Signed-off-by: Jeremy Allison Reviewed-by: Ralph Boehme Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Feb 2 21:50:31 UTC 2022 on sn-devel-184 (cherry picked from commit ca60f6350d566b7ecc822bcbb44fb65a1d150bbe) Autobuild-User(v4-16-test): Jule Anger Autobuild-Date(v4-16-test): Fri Feb 4 08:41:09 UTC 2022 on sn-devel-184 --- selftest/knownfail.d/libsmbclient_rename | 1 - source3/libsmb/clifile.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) delete mode 100644 selftest/knownfail.d/libsmbclient_rename diff --git a/selftest/knownfail.d/libsmbclient_rename b/selftest/knownfail.d/libsmbclient_rename deleted file mode 100644 index 88343b7d5ef..00000000000 --- a/selftest/knownfail.d/libsmbclient_rename +++ /dev/null @@ -1 +0,0 @@ -^samba4.libsmbclient.rename.SMB3.rename\(nt4_dc\) diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c index f1d0a9483f6..3c3f44923fc 100644 --- a/source3/libsmb/clifile.c +++ b/source3/libsmb/clifile.c @@ -1489,6 +1489,7 @@ NTSTATUS cli_rename(struct cli_state *cli, } status = cli_rename_recv(req); + cli->raw_status = status; /* cli_smb2_rename_recv doesn't set this */ fail: TALLOC_FREE(frame);