sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Code

ldap: test for empty attributes list

Browse Source 
Test for LDAP request with an empty attribute list.  LDB responds with
no attributes, but LDAP responds with all attributes.  Fix is attached
to the bug below but we can't push it upstream until we've found all
instances of incorrect empty attribute list usage in Samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13852

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Aaron Haslett 2019-03-20 19:17:07 +13:00 committed by Garming Sam
parent ad3af7cdff
commit 64bccb9bca
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
selftest/knownfail.d/ldap
View File

@ -1,2 +1,3 @@
# the attributes too long test returns the wrong error
^samba4.ldap.python.+test_attribute_ranges_too_long
^samba4.ldap.python.+test_attribute_ranges_too_long
samba4.ldap.python\(ad_dc_default\).*__main__.BasicTests.test_ldapSearchNoAttributes

17
source4/dsdb/tests/python/ldap.py
View File

@ -3175,6 +3175,23 @@ nTSecurityDescriptor:: """ + desc_base64
self.assertTrue(len(res[0]["msTSExpireDate"]) == 1)
self.assertEquals(str(res[0]["msTSExpireDate"][0]), v_get)
def test_ldapSearchNoAttributes(self):
"""Testing ldap search with no attributes"""
user_name = "testemptyattributesuser"
user_dn = "CN=%s,%s" % (user_name, self.base_dn)
delete_force(self.ldb, user_dn)
self.ldb.add({"dn": user_dn,
"objectClass": "user",
"sAMAccountName": user_name})
res = self.ldb.search(user_dn, scope=SCOPE_BASE, attrs=[])
delete_force(self.ldb, user_dn)
self.assertEqual(len(res), 1)
self.assertEqual(len(res[0]), 0)
class BaseDnTests(samba.tests.TestCase):