sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Code

r14156: Fix coverity #114: free storage alloc'ed by sstring_sub()

Browse Source
This commit is contained in:
Jim McDonough 2006-03-10 14:28:51 +00:00 committed by Gerald (Jerry) Carter
parent a197b8c5cb
commit 655fb66b28
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/utils/net_rpc_samsync.c
View File

@ -1455,7 +1455,7 @@ static NTSTATUS fetch_account_info_to_ldif(SAM_DELTA_CTR *delta, GROUPMAP *group
fstring hex_nt_passwd, hex_lm_passwd;
fstring description, fullname, sambaSID;
uchar lm_passwd[16], nt_passwd[16];
char *flags;
char *flags, *user_rdn;
const char* nopasswd = "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX";
static uchar zero_buf[16];
uint32 rid = 0, group_rid = 0, gidNumber = 0;
@ -1551,10 +1551,11 @@ static NTSTATUS fetch_account_info_to_ldif(SAM_DELTA_CTR *delta, GROUPMAP *group
NEW_PW_FORMAT_SPACE_PADDED_LEN);
/* Add the user to the temporary add ldif file */
fprintf(add_fd, "# %s, %s, %s\n", username,
sstring_sub(lp_ldap_user_suffix(), '=', ','), suffix);
fprintf(add_fd, "dn: uid=%s,ou=%s,%s\n", username,
sstring_sub(lp_ldap_user_suffix(), '=', ','), suffix);
/* this isn't quite right...we can't assume there's just OU=. jmcd */
user_rdn = sstring_sub(lp_ldap_user_suffix(), '=', ',');
fprintf(add_fd, "# %s, %s, %s\n", username, user_rdn, suffix);
fprintf(add_fd, "dn: uid=%s,ou=%s,%s\n", username, user_rdn, suffix);
SAFE_FREE(user_rdn);
fprintf(add_fd, "ObjectClass: top\n");
fprintf(add_fd, "objectClass: inetOrgPerson\n");
fprintf(add_fd, "objectClass: posixAccount\n");