1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-26 21:57:41 +03:00

s4-auth: fixed crash in krb5 auth

remote_addr was used after free
This commit is contained in:
Andrew Tridgell 2010-11-14 13:40:02 +11:00
parent f198c901dd
commit 6582d4739c

View File

@ -207,7 +207,6 @@ krb5_error_code smb_krb5_send_and_recv_func(krb5_context context,
{
krb5_error_code ret;
NTSTATUS status;
struct socket_address *remote_addr;
const char *name;
struct addrinfo *ai, *a;
struct smb_krb5_socket *smb_krb5;
@ -240,6 +239,7 @@ krb5_error_code smb_krb5_send_and_recv_func(krb5_context context,
}
for (a = ai; a; a = ai->ai_next) {
struct socket_address *remote_addr;
smb_krb5 = talloc(tmp_ctx, struct smb_krb5_socket);
if (!smb_krb5) {
talloc_free(tmp_ctx);
@ -291,7 +291,6 @@ krb5_error_code smb_krb5_send_and_recv_func(krb5_context context,
talloc_free(smb_krb5);
continue;
}
talloc_free(remote_addr);
/* Setup the FDE, start listening for read events
* from the start (otherwise we may miss a socket