sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4-ldb: fixed sorting of module names

Browse Source 
this should also fix a valgrind error on freebsd

thanks to Matthieu for spotting this
This commit is contained in:
Andrew Tridgell 2010-11-03 20:37:08 +11:00
parent 598b565980
commit 6614f847e0
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source4/lib/ldb/common/ldb_modules.c
View File

@ -906,6 +906,11 @@ static int ldb_modules_load_one(const char *path, const char *version)
return ret;
}
static int qsort_string(const char **s1, const char **s2)
{
return strcmp(*s1, *s2);
}
/*
load all modules from the given ldb modules directory. This is run once
@ -961,7 +966,7 @@ static int ldb_modules_load_dir(const char *modules_dir, const char *version)
closedir(dir);
/* sort the directory, so we get consistent load ordering */
qsort(modlist, num_modules, sizeof(modlist[0]), QSORT_CAST strcmp);
TYPESAFE_QSORT(modlist, num_modules, qsort_string);
for (i=0; i<num_modules; i++) {
int ret = ldb_modules_load_one(modlist[i], version);