sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

util:charset:codepoints: condepoint_cmpi uses NUMERIC_CMP()

Browse Source 
If these are truly unicode codepoints (< ~2m) there is no overflow,
but the type is defined as uint32_t.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2024-04-03 15:53:29 +13:00 committed by Andrew Bartlett
parent d4ce8231f9
commit 675fdeee3d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/util/charset/codepoints.c
View File

@ -26,6 +26,7 @@
#include "dynconfig/dynconfig.h"
#include "lib/util/debug.h"
#include "lib/util/byteorder.h"
#include "lib/util/tsort.h"
#ifdef strcasecmp
#undef strcasecmp
@ -16483,7 +16484,7 @@ _PUBLIC_ int codepoint_cmpi(codepoint_t c1, codepoint_t c2)
toupper_m(c1) == toupper_m(c2)) {
return 0;
}
return c1 - c2;
return NUMERIC_CMP(c1, c2);
}