sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Code

Fix for bug #334. We don't unmarshall the trusted domain or secrets

Browse Source 
info delta correctly and thus crash when doing a net rpc samdump.

The easiest thing at the moment it to comment out these functions as
they seriously don't correspond with reality (netmon/ethereal) and the
data in the containers aren't used anyway.
This commit is contained in:
Tim Potter 0001-01-01 00:00:00 +00:00
parent 3aab7a3bc7
commit 695aa39c5d
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source/rpc_parse/parse_net.c
View File

@ -2447,6 +2447,10 @@ static BOOL net_io_sam_policy_info(const char *desc, SAM_DELTA_POLICY *info,
return True;
}
#if 0
/* This function is pretty broken - see bug #334 */
/*******************************************************************
reads or writes a structure.
********************************************************************/
@ -2495,6 +2499,12 @@ static BOOL net_io_sam_trustdoms_info(const char *desc, SAM_DELTA_TRUSTDOMS *inf
return True;
}
#endif
#if 0
/* This function doesn't work - see bug #334 */
/*******************************************************************
reads or writes a structure.
********************************************************************/
@ -2582,6 +2592,8 @@ static BOOL net_io_sam_secret_info(const char *desc, SAM_DELTA_SECRET *info,
return True;
}
#endif
/*******************************************************************
reads or writes a structure.
********************************************************************/
@ -2726,14 +2738,10 @@ static BOOL net_io_sam_delta_ctr(const char *desc, uint8 sess_key[16],
return False;
break;
case SAM_DELTA_TRUST_DOMS:
if (!net_io_sam_trustdoms_info("", &delta->trustdoms_info, ps, depth))
return False;
break;
/* These guys are implemented but broken */
case SAM_DELTA_TRUST_DOMS:
case SAM_DELTA_SECRET_INFO:
if (!net_io_sam_secret_info("", &delta->secret_info, ps, depth))
return False;
break;
/* These guys are not implemented yet */