sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-29 15:42:04 +03:00
Code Activity

samba-tool: validate password early in domain provision

Browse Source 
Checks password against default quality and length standards when it is entered,
allowing a second chance to enter one (if interactive), rather than running
through the provisioning process and bailing on an exception

Includes unit tests for the newly-added python wrapper of check_password_quality
plus black-box tests for the checks in samba-tool.

Breaks an openldap test which uses an invalid password.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9710
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12235

Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Jamie McClymont
2017-11-28 15:45:30 +13:00
committed by Andrew Bartlett
parent 704bbae25c
commit 698d28ee8c
10 changed files with 157 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
python/samba/tests/password_quality.py Normal file
View File

@ -0,0 +1,51 @@
# -*- coding: utf-8 -*-
# Unix SMB/CIFS implementation.
# Copyright (C) Catalyst IT Ltd. 2017
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
"""Tests for the python wrapper of the check_password_quality function
"""
from samba import check_password_quality
from samba.tests import TestCase, TestCaseInTempDir
class PasswordQualityTests(TestCase):
def test_check_password_quality(self):
self.assertFalse(check_password_quality(""),
"empty password")
self.assertFalse(check_password_quality("a"),
"one char password")
self.assertFalse(check_password_quality("aaaaaaaaaaaa"),
"same char password")
self.assertFalse(check_password_quality("BLA"),
"multiple upcases password")
self.assertFalse(check_password_quality("123"),
"digits only")
self.assertFalse(check_password_quality("matthiéu"),
"not enough high symbols")
self.assertFalse(check_password_quality("abcdééàçè"),
"only lower case")
self.assertFalse(check_password_quality("abcdééàçè+"),
"only lower and symbols")
self.assertTrue(check_password_quality("abcdééàçè+ढ"),
"valid")
self.assertTrue(check_password_quality("ç+ढ"),
"valid")
self.assertTrue(check_password_quality("A2e"),
"valid")
self.assertTrue(check_password_quality("BA2eLi443"),
"valid")