sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-10-25 19:33:18 +03:00
Code Activity

r8247: remove the free of fullname in nbtname.c for now.

Browse Source 
Metze, the ndr_token_store() code is storing temporary pointers into
this string in the token list, which means we are referring to freed
memory when we scan the token list. A better key might be a pointer
into the ndr buffer?
This commit is contained in:
Andrew Tridgell
2005-07-09 01:53:57 +00:00
committed by Gerald (Jerry) Carter
parent 44338b2852
commit 6a4e8cc991
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/libcli/nbt/nbtname.c
View File

@@ -343,8 +343,12 @@ NTSTATUS ndr_push_nbt_name(struct ndr_push *ndr, int ndr_flags, const struct nbt
}
status = ndr_push_nbt_string(ndr, ndr_flags, fullname);
#if 0
/* this free conflicts with the use of pointers into strings
in the ndr_token_store() calls above. Metze, can you look
at this? */
talloc_free(fullname);
#endif
return status;
}