From 6b2de4748889a0b5674758169439cb7fb2106e7d Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Fri, 3 Nov 2023 12:00:15 +1300 Subject: [PATCH] =?UTF-8?q?tests/krb5:=20Remove=20unused=20parameter=20?= =?UTF-8?q?=E2=80=98expected=5Fdevice=5Fgroups=E2=80=99?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was never passed in by any callers. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- python/samba/tests/krb5/conditional_ace_tests.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/python/samba/tests/krb5/conditional_ace_tests.py b/python/samba/tests/krb5/conditional_ace_tests.py index d827943382a..8d7f8b768a0 100755 --- a/python/samba/tests/krb5/conditional_ace_tests.py +++ b/python/samba/tests/krb5/conditional_ace_tests.py @@ -3165,7 +3165,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): device_sids=None, device_claims=None, expected_groups=None, - expected_device_groups=None, expected_claims=None): try: code, crashes_windows = code @@ -3179,7 +3178,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): self.assertIsNone(device_from_rodc) self.assertIsNone(device_sids) self.assertIsNone(device_claims) - self.assertIsNone(expected_device_groups) if client_from_rodc is None: client_from_rodc = False @@ -3274,7 +3272,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): domain_sid_str = samdb.get_domain_sid() expected_groups = self.map_sids(expected_groups, None, domain_sid_str) - expected_device_groups = self.map_sids(expected_device_groups, None, domain_sid_str) # Show that obtaining a service ticket is allowed. self._tgs_req(client_tgt, code, client_creds, target_creds, @@ -3284,9 +3281,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): decryption_key=target_decryption_key, expected_sid=client_sid, expected_groups=expected_groups, - expect_device_info=bool(expected_device_groups) or None, - expected_device_domain_sid=domain_sid_str, - expected_device_groups=expected_device_groups, expect_client_claims=bool(expected_claims) or None, expected_client_claims=expected_claims, expected_supported_etypes=target_etypes,