sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4:kdc: Do not panic if authsam_logon_success_accounting() fails

Browse Source 
In hdb_samba4_audit(), ERR_GENERIC signals an unexpected situation — if
we encounter that error code while running under selftest, we’ll panic.
In response to an expected event such as the failure of
authsam_logon_success_accounting(), it’s more appropriate to continue to
run.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-08-14 10:50:37 +12:00 committed by Andrew Bartlett
parent 448cc122a8
commit 6b580f7368
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source4/kdc/hdb-samba4.c
View File

@ -900,7 +900,7 @@ static krb5_error_code hdb_samba4_audit(krb5_context context,
r->error_code = final_ret = KRB5KDC_ERR_CLIENT_REVOKED;
rwdc_fallback = kdc_db_ctx->rodc;
} else if (!NT_STATUS_IS_OK(status)) {
r->error_code = final_ret = KRB5KRB_ERR_GENERIC;
r->error_code = final_ret = KRB5KDC_ERR_CLIENT_REVOKED;
rwdc_fallback = kdc_db_ctx->rodc;
} else {
if (r->error_code == KRB5KDC_ERR_NEVER_VALID) {