sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-29 15:42:04 +03:00
Code Activity

dbcheck: Improve dbcheck to find (and may fix) dangling msDS-RevealedUsers

Browse Source 
We cannot add missing backlinks because of the duplicate checking. There
seems to be no trivial way to add the bypass.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Garming Sam
2017-03-03 17:31:46 +13:00
committed by Andrew Bartlett
parent 6b2425343b
commit 6bbcd3bbd8
7 changed files with 189 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
python/samba/dbchecker.py
View File

@ -973,6 +973,54 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base)))
if v_guid == obj_guid:
match_count += 1
if match_count != 1:
reverse_syntax_oid = self.samdb_schema.get_syntax_oid_from_lDAPDisplayName(reverse_link_name)
if syntax_oid == dsdb.DSDB_SYNTAX_BINARY_DN or reverse_syntax_oid == dsdb.DSDB_SYNTAX_BINARY_DN:
if not linkID & 1:
# Forward binary multi-valued linked attribute
forward_count = 0
for w in obj[attrname]:
w_guid = dsdb_Dn(self.samdb, w).dn.get_extended_component("GUID")
if w_guid == guid:
forward_count += 1
if match_count == forward_count:
continue
error_count += 1
# Add or remove the missing number of backlinks
diff_count = forward_count - match_count
# Loop until the difference between the forward and
# the backward links is resolved.
while diff_count != 0:
if diff_count > 0:
# self.err_missing_backlink(obj, attrname,
# obj.dn.extended_str(),
# reverse_link_name,
# dsdb_dn.dn)
# diff_count -= 1
# TODO no method to fix these right now
self.report("ERROR: Can't fix missing "
"multi-valued backlinks on %s" % str(dsdb_dn.dn))
break
else:
self.err_orphaned_backlink(res[0], reverse_link_name,
obj.dn.extended_str(), attrname,
dsdb_dn.dn)
diff_count += 1
else:
# If there's a backward link on binary multi-valued linked attribute,
# let the check on the forward link remedy the value.
# UNLESS, there is no forward link detected.
if match_count == 0:
self.err_orphaned_backlink(obj, attrname,
val, reverse_link_name,
dsdb_dn.dn)
continue
error_count += 1
if linkID & 1:
# Backlink exists, but forward link does not