sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code

s4:ldb - fixed dangling pointer in ldb_request_add_control()

Browse Source
This commit is contained in:
Endi S. Dewata 2009-10-14 00:54:52 -05:00 committed by Matthias Dieter Wallnöfer
parent 180ca8ed88
commit 6cb652e05c
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source4/lib/ldb/common/ldb_controls.c
View File

@ -123,7 +123,7 @@ int check_critical_controls(struct ldb_control **controls)
int ldb_request_add_control(struct ldb_request *req, const char *oid, bool critical, void *data)
{
unsigned n;
unsigned i, n;
struct ldb_control **ctrls;
struct ldb_control *ctrl;
@ -135,10 +135,15 @@ int ldb_request_add_control(struct ldb_request *req, const char *oid, bool criti
n++;
}
ctrls = talloc_realloc(req, req->controls,
ctrls = talloc_array(req,
struct ldb_control *,
n + 2);
if (!ctrls) return LDB_ERR_OPERATIONS_ERROR;
for (i=0; i<n; i++) {
ctrls[i] = req->controls[i];
}
req->controls = ctrls;
ctrls[n] = NULL;
ctrls[n+1] = NULL;