diff --git a/python/samba/netcmd/visualize.py b/python/samba/netcmd/visualize.py index d81bafe52ba..71965799b44 100644 --- a/python/samba/netcmd/visualize.py +++ b/python/samba/netcmd/visualize.py @@ -158,6 +158,8 @@ class GraphCommand(Command): return None if color == 'auto': + if os.environ.get('NO_COLOR'): + return None if isinstance(output, str) and output != '-': return None if not hasattr(self.outf, 'isatty'): diff --git a/selftest/knownfail.d/samba-tool-visualize b/selftest/knownfail.d/samba-tool-visualize deleted file mode 100644 index e92dd83a8fb..00000000000 --- a/selftest/knownfail.d/samba-tool-visualize +++ /dev/null @@ -1 +0,0 @@ -samba.tests.samba_tool.visualize.samba.tests.samba_tool.visualize.SambaToolVisualizeLdif.test_colour_auto_tty