sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

r6271: Don't zero the cli_credentials structure - instead allow valgrind to

Browse Source 
track the use of un-initialised values.

This change will require a recompile from clean, as the enum
describing the status of each element now has a default of
CRED_UNINITIALISED.

Andrew Bartlett
(This used to be commit 83c2eb806d)
This commit is contained in:
Andrew Bartlett 2005-04-10 10:11:36 +00:00 committed by Gerald (Jerry) Carter
parent 20841a25ad
commit 6d1ae6d35a
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source4/include/credentials.h
View File

@ -23,7 +23,8 @@
/* In order of priority */
enum credentials_obtained {
CRED_GUESSED = 0, /* Current value should be used, which was guessed */
CRED_UNINITIALISED = 0, /* We don't even have a guess yet */
CRED_GUESSED, /* Current value should be used, which was guessed */
CRED_CALLBACK, /* Callback should be used to obtain value */
CRED_SPECIFIED /* Was explicitly specified on the command-line */
};

8
source4/lib/credentials.c
View File

@ -32,11 +32,17 @@
*/
struct cli_credentials *cli_credentials_init(TALLOC_CTX *mem_ctx)
{
struct cli_credentials *cred = talloc_zero(mem_ctx, struct cli_credentials);
struct cli_credentials *cred = talloc(mem_ctx, struct cli_credentials);
if (!cred) {
return cred;
}
cred->machine_account_pending = False;
cred->workstation_obtained = CRED_UNINITIALISED;
cred->username_obtained = CRED_UNINITIALISED;
cred->password_obtained = CRED_UNINITIALISED;
cred->domain_obtained = CRED_UNINITIALISED;
cred->realm_obtained = CRED_UNINITIALISED;
return cred;
}