sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4/test-libnet: Refactor test_user_create() little bit to:

Browse Source 
- fix a flaw that user RID is not returned in case
  user is recreated
- close unused policy handle to created user
- do not take into account the result from
  test_samr_close_handle - we don't case
This commit is contained in:
Kamen Mazdrashki 2010-06-11 15:37:12 +03:00
parent a735c1ade2
commit 6eecb968cb
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source4/torture/libnet/utils.c
View File

@ -253,7 +253,8 @@ bool test_user_create(struct torture_context *tctx,
r.in.account_name = &username;
r.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
r.out.user_handle = &user_handle;
r.out.rid = &user_rid;
/* return user's RID only if requested */
r.out.rid = rid ? rid : &user_rid;
torture_comment(tctx, "creating user '%s'\n", username.string);
@ -280,21 +281,16 @@ bool test_user_create(struct torture_context *tctx,
torture_assert_ntstatus_ok(tctx, r.out.result,
"CreateUser failed");
/* be nice and close opened handles */
test_samr_close_handle(tctx, b, mem_ctx, &user_handle);
return true;
}
return false;
}
torture_comment(tctx, "closing user '%s'\n", username.string);
if (!test_samr_close_handle(tctx, b, mem_ctx, &user_handle)) {
return false;
}
/* return user RID only if requested */
if (rid) {
*rid = user_rid;
}
/* be nice and close opened handles */
test_samr_close_handle(tctx, b, mem_ctx, &user_handle);
return true;
}