sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

auth: Free empty SID arrays

Browse Source 
In the unlikely event that these arrays are empty, they can be freed
early.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2022-12-22 12:50:26 +13:00 committed by Andrew Bartlett
parent 77036bba01
commit 6f09f06adc
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
auth/auth_sam_reply.c
View File

@ -270,6 +270,10 @@ static NTSTATUS auth_convert_user_info_dc_sambaseinfo(TALLOC_CTX *mem_ctx,
sam->groups.rids[sam->groups.count].attributes = group_sid->attrs;
sam->groups.count += 1;
}
if (sam->groups.count == 0) {
TALLOC_FREE(sam->groups.rids);
}
}
sam->user_flags = info->user_flags; /* w2k3 uses NETLOGON_EXTRA_SIDS | NETLOGON_NTLMV2_ENABLED */
@ -395,7 +399,7 @@ NTSTATUS auth_convert_user_info_dc_saminfo6(TALLOC_CTX *mem_ctx,
if (sam6->sidcount) {
sam6->base.user_flags |= NETLOGON_EXTRA_SIDS;
} else {
sam6->sids = NULL;
TALLOC_FREE(sam6->sids);
}
if (user_info_dc->info->dns_domain_name != NULL) {