sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-03 01:18:10 +03:00
Code

s3:rpc_client: require DCERPC_BIND_ACK_RESULT_ACCEPTANCE for the negotiated presentation context

Browse Source 
We should fail if we didn't get DCERPC_BIND_ACK_RESULT_ACCEPTANCE.

It's also not needed to require a single array element.

We already checked above that we have at least one.

The next patch will all bind time feature negotiation
and that means we'll have 2 array elements...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Stefan Metzmacher 2024-04-19 01:17:46 +02:00
parent 6548ccb31b
commit 713a802257
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source3/rpc_client/cli_pipe.c
View File

@ -1679,9 +1679,10 @@ static bool check_bind_response(const struct dcerpc_bind_ack *r,
return False; return False;
} }
if (r->num_results != 0x1 || ctx.result != 0) { if (ctx.result != DCERPC_BIND_ACK_RESULT_ACCEPTANCE) {
DEBUG(2,("bind_rpc_pipe: bind denied results: %d reason: %x\n", DBG_NOTICE("bind denied result: %d reason: %x\n",
r->num_results, ctx.reason.value)); ctx.result, ctx.reason.value);
return false;
} }
DEBUG(5,("check_bind_response: accepted!\n")); DEBUG(5,("check_bind_response: accepted!\n"));