1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00

rpc_server3: Remove pipes_struct->pipe_bound

Only used in pipe_access_check(), superseded by dcesrv_call_auth_info()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Volker Lendecke 2021-10-04 12:49:56 +02:00 committed by Jeremy Allison
parent cdc18db7e2
commit 716727c020
4 changed files with 11 additions and 17 deletions

View File

@ -226,11 +226,6 @@ sub boilerplate_iface($)
$self->pidl("static NTSTATUS $name\__op_bind(struct dcesrv_connection_context *context, const struct dcesrv_interface *iface)");
$self->pidl("{");
$self->indent();
$self->pidl("struct pipes_struct *p = NULL;");
$self->pidl("");
$self->pidl("/* Retrieve pipes struct */");
$self->pidl("p = dcesrv_get_pipes_struct(context->conn);");
$self->pidl("p->pipe_bound = true;");
$self->pidlnoindent("#ifdef DCESRV_INTERFACE_$uname\_BIND");
$self->pidl("return DCESRV_INTERFACE_$uname\_BIND(context,iface);");
$self->pidlnoindent("#else");

View File

@ -204,9 +204,18 @@ bool pipe_access_check(struct pipes_struct *p)
if (lp_restrict_anonymous() > 0) {
struct dcesrv_call_state *dce_call = p->dce_call;
struct dcesrv_auth *auth_state = dce_call->auth_state;
enum dcerpc_AuthType auth_type = DCERPC_AUTH_TYPE_NONE;
if (!auth_state->auth_finished) {
return false;
}
dcesrv_call_auth_info(dce_call, &auth_type, NULL);
/* schannel, so we must be ok */
if (p->pipe_bound &&
(p->auth.auth_type == DCERPC_AUTH_TYPE_SCHANNEL)) {
if (auth_type == DCERPC_AUTH_TYPE_SCHANNEL) {
return True;
}

View File

@ -44,11 +44,6 @@ struct pipes_struct {
struct pipe_auth_data auth;
/*
* Set to true when an RPC bind has been done on this pipe.
*/
bool pipe_bound;
/*
* Set the DCERPC_FAULT to return.
*/

View File

@ -33,11 +33,6 @@ static bool forward_opnum_to_spoolss(uint16_t opnum) {
/* iremotewinspool - dcerpc server boilerplate generated by pidl */
static NTSTATUS iremotewinspool__op_bind(struct dcesrv_connection_context *context, const struct dcesrv_interface *iface)
{
struct pipes_struct *p = NULL;
/* Retrieve pipes struct */
p = dcesrv_get_pipes_struct(context->conn);
p->pipe_bound = true;
#ifdef DCESRV_INTERFACE_IREMOTEWINSPOOL_BIND
return DCESRV_INTERFACE_IREMOTEWINSPOOL_BIND(context,iface);
#else