sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

s4:RPC-NETLOGON: remove useless rpc callback

Browse Source 
If we got a failure from one request we bail out early.

metze
This commit is contained in:
Stefan Metzmacher 2010-02-27 10:02:40 +01:00
parent 22b1e0bf32
commit 719cecba84
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
source4/torture/rpc/netlogon.c
View File

@ -2629,15 +2629,6 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
return true;
}
static void async_callback(struct rpc_request *req)
{
int *counter = (int *)req->async.private_data;
if (NT_STATUS_IS_OK(req->status)) {
(*counter)++;
}
}
static bool test_GetDomainInfo_async(struct torture_context *tctx,
struct dcerpc_pipe *p,
struct cli_credentials *machine_credentials)
@ -2651,7 +2642,6 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
struct netlogon_creds_CredentialState *creds_async[ASYNC_COUNT];
struct rpc_request *req[ASYNC_COUNT];
int i;
int *async_counter = talloc(tctx, int);
union netr_WorkstationInfo query;
union netr_DomainInfo info;
@ -2680,17 +2670,12 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
query.workstation_info = &q1;
*async_counter = 0;
for (i=0;i<ASYNC_COUNT;i++) {
netlogon_creds_client_authenticator(creds, &a);
creds_async[i] = (struct netlogon_creds_CredentialState *)talloc_memdup(creds, creds, sizeof(*creds));
req[i] = dcerpc_netr_LogonGetDomainInfo_send(p, tctx, &r);
req[i]->async.callback = async_callback;
req[i]->async.private_data = async_counter;
/* even with this flush per request a w2k3 server seems to
clag with multiple outstanding requests. bleergh. */
torture_assert_int_equal(tctx, event_loop_once(dcerpc_event_context(p)), 0,
@ -2708,9 +2693,7 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
}
torture_comment(tctx,
"Testing netr_LogonGetDomainInfo - async count %d OK\n", *async_counter);
torture_assert_int_equal(tctx, (*async_counter), ASYNC_COUNT, "int");
"Testing netr_LogonGetDomainInfo - async count %d OK\n", ASYNC_COUNT);
return true;
}