1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

s4-dsdb: use constant-time search for descriptor -> get_last_structural_class()

The objectClass list is sorted at this point, as we are called below
the objectclass module here, or are working from a search result.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Mar 26 05:38:13 CEST 2012 on sn-devel-104
This commit is contained in:
Andrew Bartlett 2012-03-26 12:06:39 +11:00
parent cb7220d721
commit 7290a62284
2 changed files with 4 additions and 2 deletions

View File

@ -543,7 +543,7 @@ static int descriptor_add(struct ldb_module *module, struct ldb_request *req)
}
objectclass = get_last_structural_class(schema, objectclass_element,
false);
true);
if (objectclass == NULL) {
return ldb_operr(ldb);
}
@ -662,7 +662,7 @@ static int descriptor_modify(struct ldb_module *module, struct ldb_request *req)
}
objectclass = get_last_structural_class(schema, objectclass_element,
false);
true);
if (objectclass == NULL) {
return ldb_operr(ldb);
}

View File

@ -150,6 +150,8 @@ static int samba_dsdb_init(struct ldb_module *module)
- extended_dn_in must be before objectclass.c, as it resolves the DN
- objectclass must be before password_hash and samldb since these LDB
modules require the expanded "objectClass" list
- objectclass must be before descriptor, as descriptor assumes that
objectClass values are sorted
- objectclass_attrs must be behind operational in order to see all
attributes (the operational module protects and therefore
suppresses per default some important ones)