sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-16 20:59:12 +03:00
Code Activity

s4-provision: fix permissions on generated DNS zone file

Browse Source 
The zone file needs to be writeable by bind to allow for it to flush
its journal on dynamic updates

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Andrew Tridgell
2010-02-17 16:29:17 +11:00
parent d14c3756e8
commit 72c0cd75e4
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
source4/scripting/python/samba/provision.py
View File

@ -1525,15 +1525,7 @@ def create_zone_file(message, paths, setup_path, dnsdomain,
except OSError:
pass
os.mkdir(dns_dir, 0770)
# chmod needed to cope with umask
os.chmod(dns_dir, 0770)
if paths.bind_gid is not None:
try:
os.chown(dns_dir, -1, paths.bind_gid)
except OSError:
message("Failed to chown %s to bind gid %u" % (dns_dir, paths.bind_gid))
os.mkdir(dns_dir, 0775)
setup_file(setup_path("provision.zone"), paths.dns, {
"HOSTNAME": hostname,
@ -1549,6 +1541,16 @@ def create_zone_file(message, paths, setup_path, dnsdomain,
"HOSTIP6_HOST_LINE": hostip6_host_line,
})
if paths.bind_gid is not None:
try:
os.chown(dns_dir, -1, paths.bind_gid)
os.chown(paths.dns, -1, paths.bind_gid)
# chmod needed to cope with umask
os.chmod(dns_dir, 0775)
os.chmod(paths.dns, 0664)
except OSError:
message("Failed to chown %s to bind gid %u" % (dns_dir, paths.bind_gid))
def create_named_conf(paths, setup_path, realm, dnsdomain,
private_dir):