sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-25 17:57:42 +03:00
Code

vfs_gpfs: check for O_PATH support in gpfswrap_fstat_x()

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14771

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
This commit is contained in:
Ralph Boehme 2021-07-29 15:53:04 +02:00
parent 1a3ac7a940
commit 730f8c49a9
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
source3/modules/vfs_gpfs.c
View File

@ -55,6 +55,9 @@ struct gpfs_config_data {
bool acl;
bool settimes;
bool recalls;
struct {
bool gpfs_fstat_x;
} pathref_ok;
};
struct gpfs_fsp_extension {
@ -1856,6 +1859,68 @@ static ssize_t vfs_gpfs_sendfile(vfs_handle_struct *handle, int tofd,
return SMB_VFS_NEXT_SENDFILE(handle, tofd, fsp, hdr, offset, n);
}
#ifdef O_PATH
static int vfs_gpfs_check_pathref_fstat_x(struct gpfs_config_data *config,
struct connection_struct *conn)
{
struct gpfs_iattr64 iattr = {0};
unsigned int litemask;
int saved_errno;
int fd;
int ret;
fd = open(conn->connectpath, O_PATH);
if (fd == -1) {
DBG_ERR("openat() of share with O_PATH failed: %s\n",
strerror(errno));
return -1;
}
ret = gpfswrap_fstat_x(fd, &litemask, &iattr, sizeof(iattr));
if (ret == 0) {
close(fd);
config->pathref_ok.gpfs_fstat_x = true;
return 0;
}
saved_errno = errno;
ret = close(fd);
if (ret != 0) {
DBG_ERR("close failed: %s\n", strerror(errno));
return -1;
}
if (saved_errno != EBADF) {
DBG_ERR("gpfswrap_fstat_x() of O_PATH handle failed: %s\n",
strerror(saved_errno));
return -1;
}
return 0;
}
#endif
static int vfs_gpfs_check_pathref(struct gpfs_config_data *config,
struct connection_struct *conn)
{
#ifndef O_PATH
/*
* This code path leaves all struct gpfs_config_data.pathref_ok members
* initialized to false.
*/
return 0;
#else
int ret;
ret = vfs_gpfs_check_pathref_fstat_x(config, conn);
if (ret != 0) {
return -1;
}
return 0;
#endif
}
static int vfs_gpfs_connect(struct vfs_handle_struct *handle,
const char *service, const char *user)
{
@ -1945,6 +2010,14 @@ static int vfs_gpfs_connect(struct vfs_handle_struct *handle,
config->recalls = lp_parm_bool(SNUM(handle->conn), "gpfs",
"recalls", true);
ret = vfs_gpfs_check_pathref(config, handle->conn);
if (ret != 0) {
DBG_ERR("vfs_gpfs_check_pathref() on [%s] failed\n",
handle->conn->connectpath);
TALLOC_FREE(config);
return -1;
}
SMB_VFS_HANDLE_SET_DATA(handle, config,
NULL, struct gpfs_config_data,
return -1);