1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-03 01:18:10 +03:00

CVE-2023-34968: rpcclient: remove response blob allocation

This is alreay done by NDR for us.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15388

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Ralph Boehme 2023-06-20 11:35:41 +02:00 committed by Jule Anger
parent 7bbaa191be
commit 739f72a070

View File

@ -144,13 +144,6 @@ static NTSTATUS cmd_mdssvc_fetch_properties(
}
request_blob.size = max_fragment_size;
response_blob.spotlight_blob = talloc_array(mem_ctx, uint8_t, max_fragment_size);
if (response_blob.spotlight_blob == NULL) {
status = NT_STATUS_INTERNAL_ERROR;
goto done;
}
response_blob.size = max_fragment_size;
len = sl_pack(d, (char *)request_blob.spotlight_blob, request_blob.size);
if (len == -1) {
status = NT_STATUS_INTERNAL_ERROR;
@ -368,15 +361,6 @@ static NTSTATUS cmd_mdssvc_fetch_attributes(
}
request_blob.size = max_fragment_size;
response_blob.spotlight_blob = talloc_array(mem_ctx,
uint8_t,
max_fragment_size);
if (response_blob.spotlight_blob == NULL) {
status = NT_STATUS_INTERNAL_ERROR;
goto done;
}
response_blob.size = max_fragment_size;
len = sl_pack(d, (char *)request_blob.spotlight_blob, request_blob.size);
if (len == -1) {
status = NT_STATUS_INTERNAL_ERROR;