sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

s4:kdc: Fix leaks of sdb_entry’s members

Browse Source 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-08-10 16:33:24 +12:00 committed by Andrew Bartlett
parent e546587280
commit 75a1beeea8
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source4/kdc/sdb.c
View File

@ -82,8 +82,13 @@ void sdb_entry_free(struct sdb_entry *s)
krb5_free_principal(NULL, s->principal); krb5_free_principal(NULL, s->principal);
sdb_keys_free(&s->keys); sdb_keys_free(&s->keys);
SAFE_FREE(s->etypes);
sdb_keys_free(&s->old_keys); sdb_keys_free(&s->old_keys);
sdb_keys_free(&s->older_keys); sdb_keys_free(&s->older_keys);
if (s->session_etypes != NULL) {
SAFE_FREE(s->session_etypes->val);
}
SAFE_FREE(s->session_etypes);
krb5_free_principal(NULL, s->created_by.principal); krb5_free_principal(NULL, s->created_by.principal);
if (s->modified_by) { if (s->modified_by) {
krb5_free_principal(NULL, s->modified_by->principal); krb5_free_principal(NULL, s->modified_by->principal);
@ -91,6 +96,8 @@ void sdb_entry_free(struct sdb_entry *s)
SAFE_FREE(s->valid_start); SAFE_FREE(s->valid_start);
SAFE_FREE(s->valid_end); SAFE_FREE(s->valid_end);
SAFE_FREE(s->pw_end); SAFE_FREE(s->pw_end);
SAFE_FREE(s->max_life);
SAFE_FREE(s->max_renew);
ZERO_STRUCTP(s); ZERO_STRUCTP(s);
} }
@ -138,6 +145,7 @@ krb5_error_code sdb_entry_set_etypes(struct sdb_entry *s)
s->etypes->val = calloc(s->etypes->len, sizeof(*s->etypes->val)); s->etypes->val = calloc(s->etypes->len, sizeof(*s->etypes->val));
if (s->etypes->val == NULL) { if (s->etypes->val == NULL) {
SAFE_FREE(s->etypes);
return ENOMEM; return ENOMEM;
} }