sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-12 20:58:37 +03:00
Code

s3:modules: Fix the horrible vfs_crossrename module

Browse Source 
It really has to be removed! ;-)

Found by covscan. The code always leaves here as the dst variable

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14940

Pair-programmed-with: Andreas Schneider <asn@samba.org>

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 4d7ed39fd8fa18f90756f215c8b0fc5d293e955e)
This commit is contained in:
Pavel Filipenský 2022-01-07 13:16:26 +01:00 committed by Jule Anger
parent 4a6e8bc5e2
commit 76e7fdb70c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source3/modules/vfs_crossrename.c
View File

@ -82,7 +82,7 @@ static NTSTATUS copy_reg(vfs_handle_struct *handle,
full_fname_src = full_path_from_dirfsp_atname(talloc_tos(),
srcfsp,
source);
if (full_fname_dst == NULL) {
if (full_fname_src == NULL) {
status = NT_STATUS_NO_MEMORY;
goto out;
}