sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code

r21998: Fix tdb keynames in netsamlogon_clear_cached_user().

Browse Source 
No point in deleting U/DOMAIN/RID and UG/DOMAIN/RID keys if we only store U/SID
and UG/SID keys :-)

Next we need to verify the need of calling netsamlogon_clear_cached_user() at all.

Guenther
This commit is contained in:
Günther Deschner 2007-03-28 10:00:42 +00:00 committed by Gerald (Jerry) Carter
parent 6b923acfee
commit 78d13f1467
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
source/libsmb/samlogon_cache.c
View File

@ -59,9 +59,10 @@ BOOL netsamlogon_cache_shutdown(void)
***********************************************************************/
void netsamlogon_clear_cached_user(TDB_CONTEXT *tdb, NET_USER_INFO_3 *user)
{
fstring domain;
TDB_DATA key;
BOOL got_tdb = False;
DOM_SID sid;
fstring key_str, sid_string;
/* We may need to call this function from smbd which will not have
winbindd_cache.tdb open. Open the tdb if a NULL is passed. */
@ -77,29 +78,24 @@ void netsamlogon_clear_cached_user(TDB_CONTEXT *tdb, NET_USER_INFO_3 *user)
got_tdb = True;
}
unistr2_to_ascii(domain, &user->uni_logon_dom, sizeof(domain) - 1);
sid_copy(&sid, &user->dom_sid.sid);
sid_append_rid(&sid, user->user_rid);
/* Clear U/DOMAIN/RID cache entry */
/* Clear U/SID cache entry */
asprintf(&key.dptr, "U/%s/%d", domain, user->user_rid);
key.dsize = strlen(key.dptr) - 1; /* keys are not NULL terminated */
fstr_sprintf(key_str, "U/%s", sid_to_string(sid_string, &sid));
DEBUG(10, ("netsamlogon_clear_cached_user: clearing %s\n", key_str));
tdb_delete(tdb, string_tdb_data(key_str));
/* Clear UG/SID cache entry */
fstr_sprintf(key_str, "UG/%s", sid_to_string(sid_string, &sid));
DEBUG(10, ("netsamlogon_clear_cached_user: clearing %s\n", key.dptr));
tdb_delete(tdb, key);
SAFE_FREE(key.dptr);
/* Clear UG/DOMAIN/RID cache entry */
asprintf(&key.dptr, "UG/%s/%d", domain, user->user_rid);
key.dsize = strlen(key.dptr) - 1; /* keys are not NULL terminated */
DEBUG(10, ("netsamlogon_clear_cached_user: clearing %s\n", key.dptr));
tdb_delete(tdb, key);
SAFE_FREE(key.dptr);
tdb_delete(tdb, string_tdb_data(key_str));
if (got_tdb)
tdb_close(tdb);