sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

libcli/smb: clang: Fix 'array access results in a null pointer deref'

Browse Source 
Fixes:

smbXcli_base.c:1239:9: warning: Array access (via field 'pending') results in a null pointer dereference <--[clang]
                req = conn->pending[0];
                      ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Noel Power 2019-07-10 10:22:49 +00:00 committed by Gary Lockyer
parent 7b8ec24ccf
commit 7a86c99ccb
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libcli/smb/smbXcli_base.c
View File

@ -1229,7 +1229,8 @@ void smbXcli_conn_disconnect(struct smbXcli_conn *conn, NTSTATUS status)
* conn->pending because that array changes in * conn->pending because that array changes in
* smbXcli_req_unset_pending. * smbXcli_req_unset_pending.
*/ */
while (talloc_array_length(conn->pending) > 0) { while (conn->pending != NULL &&
talloc_array_length(conn->pending) > 0) {
struct tevent_req *req; struct tevent_req *req;
struct smbXcli_req_state *state; struct smbXcli_req_state *state;
struct tevent_req **chain; struct tevent_req **chain;