sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

s3: smbd: Get a parent pathref in create_file_unixpath().

Browse Source 
Not yet used.

We will be passing this down to open_directory() and
open_file_ntcreate() and using it within create_file_unixpath()
as all of these functions need a parent pathref to check parent
ACLs etc.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Jeremy Allison 2021-05-24 16:09:24 -07:00 committed by Ralph Boehme
parent daadab4a85
commit 7aa5acb895
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
source3/smbd/open.c
View File

@ -5722,6 +5722,8 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
files_struct *fsp = NULL; files_struct *fsp = NULL;
NTSTATUS status; NTSTATUS status;
int ret; int ret;
struct smb_filename *parent_dir_fname = NULL;
struct smb_filename *smb_fname_atname = NULL;
DBG_DEBUG("create_file_unixpath: access_mask = 0x%x " DBG_DEBUG("create_file_unixpath: access_mask = 0x%x "
"file_attributes = 0x%x, share_access = 0x%x, " "file_attributes = 0x%x, share_access = 0x%x, "
@ -6025,6 +6027,20 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
fsp_set_base_fsp(fsp, base_fsp); fsp_set_base_fsp(fsp, base_fsp);
} }
/*
* Get a pathref on the parent. We can re-use this
* for multiple calls to check parent ACLs etc. to
* avoid pathname calls.
*/
status = parent_pathref(talloc_tos(),
conn->cwd_fsp,
smb_fname,
&parent_dir_fname,
&smb_fname_atname);
if (!NT_STATUS_IS_OK(status)) {
goto fail;
}
/* /*
* If it's a request for a directory open, deal with it separately. * If it's a request for a directory open, deal with it separately.
*/ */
@ -6219,6 +6235,8 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
smb_fname->st = fsp->fsp_name->st; smb_fname->st = fsp->fsp_name->st;
TALLOC_FREE(parent_dir_fname);
return NT_STATUS_OK; return NT_STATUS_OK;
fail: fail:
@ -6237,6 +6255,9 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
close_file(req, base_fsp, ERROR_CLOSE); close_file(req, base_fsp, ERROR_CLOSE);
base_fsp = NULL; base_fsp = NULL;
} }
TALLOC_FREE(parent_dir_fname);
return status; return status;
} }