sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-29 02:50:28 +03:00
Code

librpc:ndr: Give the optimizer hints for ndr_push_bytes()

Browse Source 
Also remove the redundant check in ndr_push_DATA_BLOB.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Dec  7 15:33:38 CET 2018 on sn-devel-144
This commit is contained in:
Andreas Schneider 2018-12-06 09:35:15 +01:00 committed by Andreas Schneider
parent d5f9bc45e2
commit 7b60d72f67
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
librpc/ndr/ndr_basic.c
View File

@ -719,10 +719,10 @@ _PUBLIC_ enum ndr_err_code ndr_pull_trailer_align(struct ndr_pull *ndr, size_t s
*/
_PUBLIC_ enum ndr_err_code ndr_push_bytes(struct ndr_push *ndr, const uint8_t *data, uint32_t n)
{
if (n == 0) {
if (unlikely(n == 0)) {
return NDR_ERR_SUCCESS;
}
if (data == NULL) {
if (unlikely(data == NULL)) {
return NDR_ERR_INVALID_POINTER;
}
NDR_PUSH_NEED_BYTES(ndr, n);
@ -1335,10 +1335,6 @@ _PUBLIC_ enum ndr_err_code ndr_push_DATA_BLOB(struct ndr_push *ndr, int ndr_flag
} else {
NDR_CHECK(ndr_push_uint3264(ndr, NDR_SCALARS, blob.length));
}
if (blob.length == 0) {
return NDR_ERR_SUCCESS;
}
NDR_CHECK(ndr_push_bytes(ndr, blob.data, blob.length));
return NDR_ERR_SUCCESS;
}