sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s3-rpc_server: Re-order local and remote address in make_server_pipes_struct()

Browse Source 
The rest of the code uses remote before local, and this
often causes bugs

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Pair-Programmed-by: Gary Lockyer <gary@catalyst.net.nz>
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Gary Lockyer 2017-03-10 12:38:33 +13:00 committed by Andrew Bartlett
parent 689e251056
commit 7bb21df258
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source3/rpc_server/rpc_ncacn_np.c
View File

@ -146,8 +146,8 @@ NTSTATUS make_internal_rpc_pipe_socketpair(TALLOC_CTX *mem_ctx,
npc->msg_ctx,
npc->pipe_name,
NCACN_NP,
npc->local_server_addr,
npc->remote_client_addr,
npc->local_server_addr,
npc->session_info,
&npc->p,
&error);

6
source3/rpc_server/rpc_server.c
View File

@ -40,8 +40,8 @@ int make_server_pipes_struct(TALLOC_CTX *mem_ctx,
struct messaging_context *msg_ctx,
const char *pipe_name,
enum dcerpc_transport_t transport,
const struct tsocket_address *local_address,
const struct tsocket_address *remote_address,
const struct tsocket_address *local_address,
struct auth_session_info *session_info,
struct pipes_struct **_p,
int *perrno)
@ -375,8 +375,8 @@ static void named_pipe_accept_done(struct tevent_req *subreq)
ret = make_server_pipes_struct(npc,
npc->msg_ctx,
npc->pipe_name, NCACN_NP,
npc->local_server_addr,
npc->remote_client_addr,
npc->local_server_addr,
npc->session_info,
&npc->p, &error);
if (ret != 0) {
@ -1121,8 +1121,8 @@ void dcerpc_ncacn_accept(struct tevent_context *ev_ctx,
ncacn_conn->msg_ctx,
pipe_name,
ncacn_conn->transport,
ncacn_conn->server,
ncacn_conn->client,
ncacn_conn->server,
ncacn_conn->session_info,
&ncacn_conn->p,
&sys_errno);

2
source3/rpc_server/rpc_server.h
View File

@ -69,8 +69,8 @@ int make_server_pipes_struct(TALLOC_CTX *mem_ctx,
struct messaging_context *msg_ctx,
const char *pipe_name,
enum dcerpc_transport_t transport,
const struct tsocket_address *local_address,
const struct tsocket_address *remote_address,
const struct tsocket_address *local_address,
struct auth_session_info *session_info,
struct pipes_struct **_p,
int *perrno);