sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code

idmap_autorid: factor out domain range fetching part from idmap_autorid_get_domainrange()

Browse Source 
Fatored out read-only function idmap_autorid_getrange() will be used elsewhere.

Pair-Programmed-With: Michael Adam <obnox@samba.org>

Signed-off-by: Atul Kulkarni <atul.kulkarni@in.ibm.com>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Atul Kulkarni 2013-08-30 16:18:39 +05:30 committed by Michael Adam
parent 94ca5dc0bd
commit 7d2fdaac6e
1 changed files with 39 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
source3/winbindd/idmap_autorid_tdb.c
View File

@ -128,6 +128,9 @@ static NTSTATUS idmap_autorid_get_domainrange_action(struct db_context *db,
range->rangenum = rangenum;
range->low_id = globalcfg->minvalue
+ range->rangenum * globalcfg->rangesize;
return NT_STATUS_OK;
error:
@ -135,25 +138,48 @@ error:
}
static NTSTATUS idmap_autorid_getrange_int(struct db_context *db,
struct autorid_range_config *range)
{
NTSTATUS status = NT_STATUS_INVALID_PARAMETER;
struct autorid_global_config *globalcfg = NULL;
fstring keystr;
if (db == NULL || range == NULL) {
DEBUG(3, ("Invalid arguments received\n"));
goto done;
}
idmap_autorid_build_keystr(range->domsid, range->domain_range_index,
keystr);
DEBUG(10, ("reading domain range for key %s\n", keystr));
status = dbwrap_fetch_uint32_bystring(db, keystr, &(range->rangenum));
if (!NT_STATUS_IS_OK(status)) {
DEBUG(1, ("Failed to read database for key %s\n", keystr));
goto done;
}
status = idmap_autorid_loadconfig(db, talloc_tos(), &globalcfg);
if (!NT_STATUS_IS_OK(status)) {
DEBUG(1, ("Failed to read global configuration"));
goto done;
}
range->low_id = globalcfg->minvalue
+ range->rangenum * globalcfg->rangesize;
TALLOC_FREE(globalcfg);
done:
return status;
}
NTSTATUS idmap_autorid_get_domainrange(struct db_context *db,
struct autorid_range_config *range,
bool read_only)
{
NTSTATUS ret;
struct autorid_global_config *globalcfg;
fstring keystr;
/*
* try to find mapping without locking the database,
* if it is not found create a mapping in a transaction unless
* read-only mode has been set
*/
idmap_autorid_build_keystr(range->domsid, range->domain_range_index,
keystr);
ret = dbwrap_fetch_uint32_bystring(db, keystr,
&(range->rangenum));
ret = idmap_autorid_getrange_int(db, range);
if (!NT_STATUS_IS_OK(ret)) {
if (read_only) {
return NT_STATUS_NOT_FOUND;
@ -162,19 +188,11 @@ NTSTATUS idmap_autorid_get_domainrange(struct db_context *db,
idmap_autorid_get_domainrange_action, range);
}
ret = idmap_autorid_loadconfig(db, talloc_tos(), &globalcfg);
if (!NT_STATUS_IS_OK(ret)) {
return ret;
}
range->low_id = globalcfg->minvalue
+ range->rangenum * globalcfg->rangesize;
DEBUG(10, ("Using range #%d for domain %s "
"(domain_range_index=%"PRIu32", low_id=%"PRIu32")\n",
range->rangenum, range->domsid, range->domain_range_index,
range->low_id));
TALLOC_FREE(globalcfg);
return ret;
}