sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

smbd: Change logging when SET_OFFLINE is not supported

Browse Source 
A client can send a request to set the OFFLINE attribute. In the default
code this is not supported and triggers a log message each time. Change
this to only log with level 0 when an actual errors occurs, and log
ENOTSUP with level 10.

Signed-off-by: Christof Schmitt <christof.schmitt@us.ibm.com>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jun  6 04:30:26 CEST 2013 on sn-devel-104
This commit is contained in:
Christof Schmitt 2013-06-05 17:08:03 -07:00 committed by Andrew Bartlett
parent 1a6eac2c37
commit 7d8354c719
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
source3/smbd/dosmode.c
View File

@ -732,16 +732,21 @@ int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
old_mode = dos_mode(conn, smb_fname);
if (dosmode & FILE_ATTRIBUTE_OFFLINE) {
if (!(old_mode & FILE_ATTRIBUTE_OFFLINE)) {
lret = SMB_VFS_SET_OFFLINE(conn, smb_fname);
if (lret == -1) {
DEBUG(0, ("set_dos_mode: client has asked to "
"set FILE_ATTRIBUTE_OFFLINE to "
"%s/%s but there was an error while "
"setting it or it is not "
"supported.\n", parent_dir,
smb_fname_str_dbg(smb_fname)));
if ((dosmode & FILE_ATTRIBUTE_OFFLINE) &&
!(old_mode & FILE_ATTRIBUTE_OFFLINE)) {
lret = SMB_VFS_SET_OFFLINE(conn, smb_fname);
if (lret == -1) {
if (errno == ENOTSUP) {
DEBUG(10, ("Setting FILE_ATTRIBUTE_OFFLINE for "
"%s/%s is not supported.\n",
parent_dir,
smb_fname_str_dbg(smb_fname)));
} else {
DEBUG(0, ("An error occurred while setting "
"FILE_ATTRIBUTE_OFFLINE for "
"%s/%s: %s", parent_dir,
smb_fname_str_dbg(smb_fname),
strerror(errno)));
}
}
}