sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-11-27 08:23:49 +03:00
Code Activity

r3278: - rewrote the client side rpc connection code to use lib/socket/

Browse Source 
rather than doing everything itself. This greatly simplifies the
  code, although I really don't like the socket_recv() interface (it
  always allocates memory for you, which means an extra memcpy in this
  code)

- fixed several bugs in the socket_ipv4.c code, in particular client
  side code used a non-blocking connect but didn't handle EINPROGRESS,
  so it had no chance of working. Also fixed the error codes, using
  map_nt_error_from_unix()

- cleaned up and expanded map_nt_error_from_unix()

- changed interpret_addr2() to not take a mem_ctx. It makes absolutely
  no sense to allocate a fixed size 4 byte structure like this. Dozens
  of places in the code were also using interpret_addr2() incorrectly
  (precisely because the allocation made no sense)
This commit is contained in:
Andrew Tridgell
2004-10-27 03:15:42 +00:00
committed by Gerald (Jerry) Carter
parent 50377db11b
commit 7f2c771b0e
20 changed files with 203 additions and 425 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/ldap_server/ldap_server.c
View File

@@ -110,13 +110,11 @@ static void ldapsrv_init(struct server_service *service,
add_socket(service, model_ops, ifip);
}
} else {
struct in_addr *ifip;
struct in_addr ifip;
/* Just bind to lp_socket_address() (usually 0.0.0.0) */
ifip = interpret_addr2(service, lp_socket_address());
add_socket(service, model_ops, ifip);
talloc_destroy(ifip);
ifip = interpret_addr2(lp_socket_address());
add_socket(service, model_ops, &ifip);
}
}