sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

Fix unintentional free of the last value when adding a new value to a key.

Browse Source 
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
This commit is contained in:
Wilco Baan Hofman 2010-01-19 12:06:01 +01:00 committed by Jelmer Vernooij
parent f8314c27b3
commit 8067bf629c
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source4/lib/registry/regf.c
View File

@ -1791,11 +1791,9 @@ static WERROR regf_set_value(struct hive_key *key, const char *name,
break;
}
}
/* Free data, if any */
if (!(vk.data_length & 0x80000000)) {
hbin_free(regf, vk.data_offset);
}
}
/* If it's new, create the vk struct, if it's old, free the old data. */
if (old_vk_offset == -1) {
vk.header = "vk";
vk.name_length = strlen(name);
@ -1806,7 +1804,13 @@ static WERROR regf_set_value(struct hive_key *key, const char *name,
vk.data_name = NULL;
vk.flag = 0;
}
} else {
/* Free data, if any */
if (!(vk.data_length & 0x80000000)) {
hbin_free(regf, vk.data_offset);
}
}
/* Set the type and data */
vk.data_length = data.length;
vk.data_type = type;