sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-08 04:58:40 +03:00
Code

ctdb-scripts: Drop use of eval in CTDB callout handling

Browse Source 
eval is not required and causes the follow ShellCheck warning:

  SC2294 (warning): eval negates the benefit of arrays. Drop eval to
  preserve whitespace/symbols (or eval as string).

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jun 24 10:40:50 UTC 2022 on sn-devel-184
This commit is contained in:
Martin Schwenke 2022-05-27 23:19:46 +10:00 committed by Amitay Isaacs
parent 4cbb0b13ba
commit 80ba66013e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ctdb/config/functions
View File

@ -920,7 +920,7 @@ nfs_callout_register ()
echo "$CTDB_NFS_CALLOUT" >"$nfs_callout_cache_callout"
_t=$(eval "$CTDB_NFS_CALLOUT" "register")
_t=$("$CTDB_NFS_CALLOUT" "register")
if [ -n "$_t" ] ; then
echo "$_t" |
while IFS="" read _op ; do
@ -945,7 +945,7 @@ nfs_callout ()
# Run the operation if it is registered...
if [ -e "${nfs_callout_cache_ops}/${1}" ] || \
[ -e "${nfs_callout_cache_ops}/ALL" ]; then
eval "$CTDB_NFS_CALLOUT" "$@"
"$CTDB_NFS_CALLOUT" "$@"
fi
}