mirror of
https://github.com/samba-team/samba.git
synced 2024-12-24 21:34:56 +03:00
Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"
This reverts commit 2ea03a1e95
.
This commit is contained in:
parent
342f885820
commit
80c2e8295a
@ -1167,20 +1167,9 @@ static bool get_dcs(TALLOC_CTX *mem_ctx, struct winbindd_domain *domain,
|
||||
|
||||
sitename = sitename_fetch(domain->alt_name);
|
||||
if (sitename) {
|
||||
NTSTATUS status;
|
||||
|
||||
/* Do the site-specific AD dns lookup first. */
|
||||
status = get_sorted_dc_list(domain->alt_name,
|
||||
sitename, &ip_list,
|
||||
&iplist_size, True);
|
||||
if (!NT_STATUS_IS_OK(status)) {
|
||||
/*
|
||||
* Work around a crappy about-to-be-replaced
|
||||
* get_sorted_dc_list error handling :-)
|
||||
*/
|
||||
SAFE_FREE(ip_list);
|
||||
iplist_size = 0;
|
||||
}
|
||||
get_sorted_dc_list(domain->alt_name, sitename, &ip_list, &iplist_size, True);
|
||||
|
||||
for ( i=0; i<iplist_size; i++ ) {
|
||||
char addr[INET6_ADDRSTRLEN];
|
||||
@ -1213,8 +1202,6 @@ static bool get_dcs(TALLOC_CTX *mem_ctx, struct winbindd_domain *domain,
|
||||
dcs,
|
||||
num_dcs);
|
||||
}
|
||||
SAFE_FREE(ip_list);
|
||||
iplist_size = 0;
|
||||
}
|
||||
|
||||
/* try standard netbios queries if no ADS */
|
||||
|
Loading…
Reference in New Issue
Block a user