sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

smbd: Simplify an if-condition

Browse Source 
current_sid == NULL is true if and only if we could not assign current_sid
because num_sids was too small. Make that more explicit.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Volker Lendecke 2024-02-09 12:37:53 +01:00 committed by Andrew Bartlett
parent 51c950c162
commit 811c184bbb
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source3/smbd/smbXsrv_open.c
View File

@ -529,17 +529,11 @@ NTSTATUS smbXsrv_open_create(struct smbXsrv_connection *conn,
}
current_token = session_info->security_token;
if (current_token == NULL) {
return NT_STATUS_INVALID_HANDLE;
}
if (current_token->num_sids > PRIMARY_USER_SID_INDEX) {
current_sid = &current_token->sids[PRIMARY_USER_SID_INDEX];
}
if (current_sid == NULL) {
if ((current_token == NULL) ||
(current_token->num_sids <= PRIMARY_USER_SID_INDEX)) {
return NT_STATUS_INVALID_HANDLE;
}
current_sid = &current_token->sids[PRIMARY_USER_SID_INDEX];
if (table->local.num_opens >= table->local.max_opens) {
return NT_STATUS_INSUFFICIENT_RESOURCES;