sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

s3: tests: Regression test to ensure we can never return a DIRECTORY attribute on a stream.

Browse Source 
Tests streams_xattr and also streams_depot.

Inspired from a real-world test case by Andrew Walker <awalker@ixsystems.com>.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 12 02:04:28 CEST 2018 on sn-devel-144
This commit is contained in:
Jeremy Allison 2018-04-11 10:33:22 -07:00
parent 118e77d86a
commit 82beaf868f
2 changed files with 80 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
selftest/target/Samba3.pm
View File

@ -2143,6 +2143,10 @@ sub provision($$$$$$$$$)
kernel oplocks = yes
vfs objects = streams_xattr xattr_tdb
[streams_xattr]
copy = tmp
vfs objects = streams_xattr xattr_tdb
[compound_find]
copy = tmp
smbd:find async delay usec = 10000

76
source3/script/tests/test_smbclient_s3.sh
View File

@ -1606,6 +1606,78 @@ EOF
return 0
}
# Test xattr_stream correctly reports mode.
# BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380
test_stream_directory_xattr()
{
tmpfile=$PREFIX/smbclient_interactive_prompt_commands
#
# Test against streams_xattr
#
cat > $tmpfile <<EOF
deltree foo
mkdir foo
put ${PREFIX}/smbclient_interactive_prompt_commands foo:bar
setmode foo -a
allinfo foo:bar
deltree foo
quit
EOF
cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT "$@" -U$USERNAME%$PASSWORD //$SERVER/streams_xattr -I $SERVER_IP $ADDARGS < $tmpfile 2>&1'
eval echo "$cmd"
out=`eval $cmd`
ret=$?
rm -f $tmpfile
if [ $ret != 0 ] ; then
echo "$out"
echo "failed checking attributes on xattr stream foo:bar with error $ret"
return 1
fi
echo "$out" | grep "attributes:.*80"
ret=$?
if [ $ret != 0 ] ; then
echo "$out"
echo "failed checking attributes on xattr stream foo:bar"
return 1
fi
#
# Test against streams_depot
#
cat > $tmpfile <<EOF
deltree foo
mkdir foo
put ${PREFIX}/smbclient_interactive_prompt_commands foo:bar
setmode foo -a
allinfo foo:bar
deltree foo
quit
EOF
cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT "$@" -U$USERNAME%$PASSWORD //$SERVER/tmp -I $SERVER_IP $ADDARGS < $tmpfile 2>&1'
eval echo "$cmd"
out=`eval $cmd`
ret=$?
rm -f $tmpfile
if [ $ret != 0 ] ; then
echo "$out"
echo "failed checking attributes on depot stream foo:bar with error $ret"
return 1
fi
echo "$out" | grep "attributes:.*80"
ret=$?
if [ $ret != 0 ] ; then
echo "$out"
echo "failed checking attributes on depot stream foo:bar"
return 1
fi
}
#
LOGDIR_PREFIX=test_smbclient_s3
# possibly remove old logdirs:
@ -1705,6 +1777,10 @@ testit "streams_depot can delete correctly" \
test_streams_depot_delete || \
failed=`expr $failed + 1`
testit "stream_xattr attributes" \
test_stream_directory_xattr || \
failed=`expr $failed + 1`
testit "follow symlinks = no" \
test_nosymlinks || \
failed=`expr $failed + 1`