sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-28 01:58:17 +03:00
Code

kcc: default to logging to DBGLVL_WARNING

Browse Source 
If the "-d" debug level parameter is not supplied, default to DBGLVL_WARNING.
Overiding the "log level" set in smb.conf.

When samba runs the kcc command stderr output is logged at DBGLVL_ERR,
the default log destination is stderr.  As a result any log messages
generated by the kcc command, are effectively logged at DBGLVL_ERR.
This causes issues if auth or audit logging are enabled in smb.conf.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Pair-programmed-with: Tim Beale <timbeale@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jul  2 05:49:43 UTC 2019 on sn-devel-184
This commit is contained in:
Gary Lockyer 2019-06-06 11:40:08 +12:00 committed by Andrew Bartlett
parent 731f0b7b52
commit 82f327fce8
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source4/scripting/bin/samba_kcc
View File

@ -250,7 +250,6 @@ parser.add_option("--forget-intersite-links", default=False,
help="pretend not to know the existing intersite topology",
action="store_true")
opts, args = parser.parse_args()
@ -286,6 +285,10 @@ else:
unix_now = int(time.time())
lp = sambaopts.get_loadparm()
# only log warnings/errors by default, unless the user has specified otherwise
if opts.debug is None:
lp.set('log level', '1')
creds = credopts.get_credentials(lp, fallback_machine=True)
if opts.dburl is None: