From 83179a74119de84d20f796c241aae6bccb83a68b Mon Sep 17 00:00:00 2001 From: Ralph Boehme Date: Wed, 22 May 2019 17:02:20 +0200 Subject: [PATCH] vfs_fruit: use correct case FRUIT_RSRC_STREAM in readdir_attr_rfork_size() This is a genuine bug, but luckily this would only impact configs which nobody uses: fruit:metadata = netatalk fruit:resource = stream With the above configuration the switch in readdir_attr_rfork_size() would hit the default case and so always report resource forks as 0 bytes in size. All deployment that I've seen that use fruit:resource=stream also use fruit:metadata=stream, so the switch takes FRUIT_META_STREAM case which runs the correct code readdir_attr_rfork_size_stream(). Bug: https://bugzilla.samba.org/show_bug.cgi?id=13968 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison --- source3/modules/vfs_fruit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c index 2bd4fbadf37..c2833fa3dff 100644 --- a/source3/modules/vfs_fruit.c +++ b/source3/modules/vfs_fruit.c @@ -3246,7 +3246,7 @@ static uint64_t readdir_attr_rfork_size(struct vfs_handle_struct *handle, smb_fname); break; - case FRUIT_META_STREAM: + case FRUIT_RSRC_STREAM: rfork_size = readdir_attr_rfork_size_stream(handle, smb_fname); break;