sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00
Code

s3: smbd: Inside call_trans2setfilepathinfo(), for the TRANSACT2_SETPATHINFO case, we don't need to re-stat.

Browse Source 
If we need a valid filesystem object, and we have a !VALID_STAT()
return from filename_convert(), the previous commit has already
errored out. We don't need a re-stat call here.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
This commit is contained in:
Jeremy Allison 2021-12-13 16:54:07 -08:00
parent d508dff634
commit 834aa7bb01
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source3/smbd/trans2.c
View File

@ -9432,24 +9432,6 @@ static void call_trans2setfilepathinfo(connection_struct *conn,
if (!VALID_STAT(smb_fname->st) && require_existing_object) {
reply_nterror(req, NT_STATUS_OBJECT_NAME_NOT_FOUND);
}
if (INFO_LEVEL_IS_UNIX(info_level)) {
/*
* For CIFS UNIX extensions the target name may not exist.
*/
/* Always do lstat for UNIX calls. */
SMB_VFS_LSTAT(conn, smb_fname);
} else if (!VALID_STAT(smb_fname->st) &&
SMB_VFS_STAT(conn, smb_fname)) {
DEBUG(3,("call_trans2setfilepathinfo: SMB_VFS_STAT of "
"%s failed (%s)\n",
smb_fname_str_dbg(smb_fname),
strerror(errno)));
reply_nterror(req, map_nt_error_from_unix(errno));
return;
}
}
DEBUG(3,("call_trans2setfilepathinfo(%d) %s (%s) info_level=%d "