From 840b8501b43695802d78726409b69afb4976166a Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 6 Jun 2019 14:07:13 +0200 Subject: [PATCH] docs-xml: change "server min protocol" to SMB2_02 SMB2_02 was available with Windows Vista. It's time to turn SMB1 off by default. Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme --- docs-xml/smbdotconf/protocol/serverminprotocol.xml | 4 ++-- lib/param/loadparm.c | 2 +- source3/param/loadparm.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs-xml/smbdotconf/protocol/serverminprotocol.xml b/docs-xml/smbdotconf/protocol/serverminprotocol.xml index 4765f5b88e0..1079eb89bae 100644 --- a/docs-xml/smbdotconf/protocol/serverminprotocol.xml +++ b/docs-xml/smbdotconf/protocol/serverminprotocol.xml @@ -10,7 +10,7 @@ Normally this option should not be set as the automatic negotiation phase in the SMB protocol takes care of choosing the appropriate - protocol. + protocol unless you have legacy clients which are SMB1 capable only. See server max protocol for a full list of available protocols. @@ -18,6 +18,6 @@ server max protocol -LANMAN1 +SMB2_02 NT1 diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c index 26b61789b3f..f3f06b69db8 100644 --- a/lib/param/loadparm.c +++ b/lib/param/loadparm.c @@ -2711,7 +2711,7 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx) lpcfg_do_global_parameter(lp_ctx, "host msdfs", "true"); lpcfg_do_global_parameter(lp_ctx, "LargeReadwrite", "True"); - lpcfg_do_global_parameter(lp_ctx, "server min protocol", "LANMAN1"); + lpcfg_do_global_parameter(lp_ctx, "server min protocol", "SMB2_02"); lpcfg_do_global_parameter(lp_ctx, "server max protocol", "SMB3"); lpcfg_do_global_parameter(lp_ctx, "client min protocol", "CORE"); lpcfg_do_global_parameter(lp_ctx, "client max protocol", "default"); diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c index c2e1f341c57..afb35696b0f 100644 --- a/source3/param/loadparm.c +++ b/source3/param/loadparm.c @@ -646,7 +646,7 @@ static void init_globals(struct loadparm_context *lp_ctx, bool reinit_globals) Globals.max_log_size = 5000; Globals.max_open_files = max_open_files(); Globals.server_max_protocol = PROTOCOL_SMB3_11; - Globals.server_min_protocol = PROTOCOL_LANMAN1; + Globals.server_min_protocol = PROTOCOL_SMB2_02; Globals._client_max_protocol = PROTOCOL_DEFAULT; Globals.client_min_protocol = PROTOCOL_CORE; Globals._client_ipc_max_protocol = PROTOCOL_DEFAULT;